search

Liquipedia / Lua-Modules

Used to keep versions of some important lua modules of the Liquipedia wiki that we want better version control for.
Other
28 stars 62 forks source link

Full Sized Game Logo #2785

Open Rathoz opened 1 year ago

Rathoz commented 1 year ago

See discussion on #fighters at and around here https://discord.com/channels/93055209017729024/202549269134180352/1088921164736376932

trevize23 commented 1 year ago

Resulting Changes:

Module:Info needs an entry for overview images; i.e.: overview = { darkMode = 'Guilty Gear -STRIVE- overview darkmode.png', lightMode = 'Guilty Gear -STRIVE- overview lightmode.png', },

Module:Game needs a function where those images are retrieved if available. if not then default to defaultTeamLogo (I think would be the correct one over logo)

hjpalpha commented 1 year ago

i don't see why defaulting to team logo over logo is a good idea

trevize23 commented 1 year ago

I suggest reading the discord discussion. The images used for defaultTeamLogo would fit better than those in logo.

hjpalpha commented 1 year ago

i stilm do not see why teamlogo is better there but whatever from the discussion it only seems useful for smash like wikis anyways so not really worth discussing what to use as fallback since for most wikis it is irrelevant anyways

iMarbot commented 1 year ago

If we do end up using a different logo (i.e., full logos) [which I like in this case], then I would suggest the following naming scheme.

File:<game name>_gamelogo_<darkmode/allmode/lightmode>.png

Coinciding with File:<game name>_gameicon_<darkmode/allmode/lightmode>.png