search

Liquipedia / Lua-Modules

Used to keep versions of some important lua modules of the Liquipedia wiki that we want better version control for.
Other
31 stars 68 forks source link

List of git-maintained modules lacking edit protection #3845

Closed iamentry closed 7 months ago

iamentry commented 7 months ago

As the title describes, many git-maintained modules don't have edit protection. Here is a list by wiki (alphabetical). This list only covers modules in the match2 folder on the git repo.

Apex Legends: Module:Brkts/WikiSpecific Module:MatchGroup/Input/Custom

Arena FPS: Module:MatchSummary Module:MatchGroup/Input/Custom Module:Match/Legacy Module:GetMatchGroupCopyPaste/wiki

Arena of Valor: Module:MatchSummary Module:Brkts/WikiSpecific Module:MatchGroup/Input/Custom Module:Match/Legacy

Brawl Stars: Module:MatchSummary Module:Match/Legacy Module:MatchGroup/Input/Custom Module:GetMatchGroupCopyPaste/wiki

Counter-Strike: Module:MatchSummary Module:GetMatchGroupCopyPaste/wiki Module:MatchExternalLinks Module:MatchGroup/Input/Custom Module:Match/Legacy

Critical Ops: Module:MatchGroup/Input/Custom Module:MatchSummary Module:Match/Legacy

Crossfire: Module:MatchGroup/Input/Custom Module:Match/Legacy Module:MatchSummary Module:Brkts/WikiSpecific

Dota2: Module:GetMatchGroupCopyPaste/wiki Module:Match/Legacy Module:MatchSummary

FIFA: Module:MatchGroup/Input/Custom Module:MatchSummary Module:Match/Legacy

Halo: Module:Match/Legacy

Heroes: Module:MatchGroup/Input/Custom Module:MatchSummary

League of Legends: Module:BigMatch Module:Match/Legacy Module:Brkts/WikiSpecific Module:GetMatchGroupCopyPaste/wiki Module:BigMatch/Template Module:MatchSummary

Mobile Legends: Module:Brkts/WikiSpecific Module:Match/Legacy Module:MatchGroup/Input/Custom Module:MatchSummary

Omega Strikers: Module:MatchSummary Module:MatchGroup/Input/Custom

osu!: Module:MatchGroup/Input/Custom Module:MatchSummary

Overwatch: Module:Match/Legacy

Pokemon: Module:MatchGroup/Input/Custom Module:Match/Legacy Module:MatchSummary Module:Brkts/WikiSpecific

Rainbow 6: Module:MatchMaps/Legacy Module:GetMatchGroupCopyPaste/wiki Module:MatchSummary

Rocket League: Module:MatchSummary Module:Match/Legacy Module:GetMatchGroupCopyPaste/wiki Module:MatchGroup/Input/Custom Module:Brkts/WikiSpecific Module:Player/Ext/Custom

Sideswipe: Module:MatchGroup/Input/Custom Module:Match/Legacy Module:MatchSummary Module:Brkts/WikiSpecific

Splatoon: Module:Match/Legacy

Splitgate: Module:MatchSummary Module:MatchGroup/Input/Custom Module:Match/Legacy

Starcraft/Brood War: Module:Match/Legacy Module:GetMatchGroupCopyPaste/wiki

Tetris: Module:Match/Legacy

Trackmania: Module:MatchSummary Module:Match/Legacy Module:Brkts/WikiSpecific

Valorant: Module:GetMatchGroupCopyPaste/wiki Module:BigMatch Module:MatchSummary Module:Match/Legacy

Warcraft: Module:MatchGroup/Util/Custom

Wildrift: Module:MatchGroup/Input/Custom Module:GetMatchGroupCopyPaste/wiki Module:Match/Legacy Module:Brkts/WikiSpecific Module:MatchSummary

World of Tanks: Module:MatchGroup/Input/Custom Module:MatchSummary

Zula: Module:MatchGroup/Input/Custom Module:MatchSummary

hjpalpha commented 7 months ago

added protection for them

@Rathoz might it be a good idea to let the deploy bot auto slap protection on modules?

Rathoz commented 7 months ago

added protection for them

@Rathoz might it be a good idea to let the deploy bot auto slap protection on modules?

Would cause 50% longer deploy times, so not a massive fan straight off the bat. I'll think about it

iamentry commented 7 months ago

Would cause 50% longer deploy times, so not a massive fan straight off the bat. I'll think about it

It's fine not to add auto-deploy protection imo. It's just a thing the admins for those wikis should look out for and be on top of.

FenrirWulf commented 7 months ago

added protection for them @Rathoz might it be a good idea to let the deploy bot auto slap protection on modules?

Would cause 50% longer deploy times, so not a massive fan straight off the bat. I'll think about it

Wouldnt this only affect the first time deployments for modules? ie if the module page is being edited by the bot for the first time or the page didnt exist before the deployment started?

Rathoz commented 7 months ago

added protection for them @Rathoz might it be a good idea to let the deploy bot auto slap protection on modules?

Would cause 50% longer deploy times, so not a massive fan straight off the bat. I'll think about it

Wouldnt this only affect the first time deployments for modules? ie if the module page is being edited by the bot for the first time or the page didnt exist before the deployment started?

We currently have no clue if the a file is being deployed for the first time or not, hence the set permissions call needs to be done every time (alternatively a call to check current permission level). In both cases in 1 extra call, which increases it from 1.5 calls/file -> 2.5 calls/file