search

Liquipedia / Lua-Modules

Used to keep versions of some important lua modules of the Liquipedia wiki that we want better version control for.
Other
31 stars 69 forks source link

Location processing in infobox league is faulty if country is detected as region #4323

Closed mbergen closed 4 months ago

mbergen commented 5 months ago

As reported on discord: https://discord.com/channels/93055209017729024/1209064462611517460/1248940608920223865

What happens is that for any input of country without a corresponding input for region, that if the country is recognized as a region (which it is for many large countries like india, china etc), the country is removed and only region is stored. This leads to display issues in the app, showing unknown flag.

This stems from some countries being defined as region: https://github.com/Liquipedia/Lua-Modules/blob/af7c28659bd3fb5bc88facbe660327ccd0359978/standard/region/commons/region_data.lua#L68-L77 https://github.com/Liquipedia/Lua-Modules/blob/af7c28659bd3fb5bc88facbe660327ccd0359978/standard/region/commons/region_data.lua#L221-L265

hjpalpha commented 5 months ago

which infobox is that for?

mbergen commented 5 months ago

which infobox is that for?

Mostly league, but i guess it could apply to others using Module:Locale to process locations for storage if they store the same way