search

Liquipedia / Lua-Modules

Used to keep versions of some important lua modules of the Liquipedia wiki that we want better version control for.
Other
31 stars 69 forks source link

feat(match2): remove strikethrough on resulttype=default #5040

Closed Rathoz closed 2 weeks ago

Rathoz commented 2 weeks ago

Summary

Remove the strikethrough on "defaults". Only keep it on notplayed.

Feedback from https://discord.com/channels/93055209017729024/1209065403955806270/1303520062531047516 which I resonate with

Before the match summary refactors I believe the only wikis that used the display helper functions were the Craft wikis. So only there there's a negative impact. But they will still display the status text when there was a "default".

How did you test this change?

Rathoz commented 2 weeks ago

code wise lgtm display wise maybe if one of the (game)opponents has a FF/DQ status it should still be strike through can completely get behind removing it for W/L

Maybe FF/DQ should have a notplayed flag 🤔

hjpalpha commented 2 weeks ago

code wise lgtm display wise maybe if one of the (game)opponents has a FF/DQ status it should still be strike through can completely get behind removing it for W/L

Maybe FF/DQ should have a notplayed flag 🤔

could be a DQ while the map is played

Rathoz commented 2 weeks ago

I'm gonna go ahead with this, and then we'll decide how to tackle FF/DQ later on.