search

Liquipedia / Lua-Modules

Used to keep versions of some important lua modules of the Liquipedia wiki that we want better version control for.
Other
31 stars 69 forks source link

feat(match2): Create hearthstone bracket match1->match2 support #5100

Closed LuckeLucky closed 5 days ago

LuckeLucky commented 1 week ago

Summary

Added a new function to legacy to map old rXmY.. Legacy default will only be used to convert solo brackets, team brackets or brackets using RX(DW)Y inputs will be handled on a case-by-case basis.

How did you test this change?

8DEBracket 4SEBracket

LuckeLucky commented 1 week ago

Why on solo matches Map input oXpY is the character input and for teams oXpY is the player input?

hjpalpha commented 1 week ago

Why on solo matches Map input oXpY is the character input and for teams oXpY is the player input?

because old stuff wasn't standardized and often didn't make sense imo

Rathoz commented 1 week ago

Why on solo matches Map input oXpY is the character input and for teams oXpY is the player input?

M1 or M2?

LuckeLucky commented 1 week ago

Why on solo matches Map input oXpY is the character input and for teams oXpY is the player input?

M1 or M2?

m2

LuckeLucky commented 5 days ago

Map input for party opponents needs to be ajusted in mgi, but there is no inpact in this pr, since oXpY will always be used to input the character.

LuckeLucky commented 5 days ago

lgtm did you test it on wikis that already use the commons parts? (just to be sure we do not break something)

yes, tested also in brackets with custom mapping