Liquipedia / Lua-Modules

Used to keep versions of some important lua modules of the Liquipedia wiki that we want better version control for.
Other
31 stars 68 forks source link

Infobox/Team standarise Region cell & lpdb field #879

Closed Rathoz closed 7 months ago

Rathoz commented 2 years ago

Background

All wikis, except Rocket League, that have implemented Infobox/Team have so far felt a need to override the default saving of the region LPDB field. This indicates the default handling is likely not optimal, and it should be improved and standardized across all wiki, or at least as many as possible.

Current Setups

hjpalpha commented 2 years ago

sc2 just kicks it (we do not use it at all as we do not have regions for teams)

but i agree that the standard storage of region should be adjusted to fit the way it is done the most

JaspervanRiet commented 2 years ago

It would be useful to describe what the actual format is of the current default, as well as the ways in which it is overwritten.

Rathoz commented 2 years ago

Added the four current implementations

JaspervanRiet commented 2 years ago

Sounds like Halo is the way to go?

Rathoz commented 2 years ago

That was my thought as well. Initial implementation for it can be found in #882.

hjpalpha commented 2 years ago

keep in mind that country to region do not have to align for players and teams, so maybe module region needs some small adjusting to make the module required into countryToRegionData depended on that also the region template also sets a wiki var, maybe it was actually needed on the page (maybe not)

Rathoz commented 2 years ago

Do you have an example where country to region should differ between Players and Teams?

hjpalpha commented 2 years ago

Do you have an example where country to region should differ between Players and Teams?

https://liquipedia.net/rocketleague/index.php?title=Template:Player_region&action=edit vs https://liquipedia.net/rocketleague/index.php?title=Template:Region&action=edit

e.g. in one russia is EU in one CIS

don't know for other wikis, would have to be checked