search

LiraShapira / app

The Lira Shapira App
4 stars 8 forks source link

Feat/55 search by pthone number #70

Closed artemNaumenko closed 11 months ago

artemNaumenko commented 1 year ago

add searching contacts by phone number add unit tests

artemNaumenko commented 11 months ago

Hi @GILREICH1, I hope you're doing well. Please, can you check this PR? Because amends due to your feedback was done more then month ago.

GILREICH1 commented 11 months ago

Hey @artemNaumenko sorry about delay in review! I have some concerns about performance of this solution with large number of contacts. Can you confirm filtering time on >300 contacts, assuming only one phone number each? If too long, maybe we should consider some solution that involves data processing on app initialization.

artemNaumenko commented 11 months ago

Hey @GILREICH1, here is result of performance check: 10 users ~ 350ms 300 users ~ 500ms In my opinion this performance is acceptable. However when I use 1000 users there was a performance problem mostly with using TextInput field. But it can be easy fixed if we change "onChangeText" to "onSubmitEditing" in the TextInput.

GILREICH1 commented 11 months ago

thanks for response artem 🙏 approved and merged 👍