LironSimon / Prediction-of-Projectile-Landing-Points-with-ML

1 stars 0 forks source link

the bug was in the solution of the 't' #1

Closed alexlib closed 3 years ago

alexlib commented 3 years ago

In the solution of 't' you use positive 'g', while it's negative in your coordinate system (at least on Earth:)) we can work in one branch where I fix the code or better we use two branches and we merge one from another when we agree on the changes. note that I also changed the set of values - but this is for simplicity and plotting of more or less realistic values. If you click on the notebook (.ipynb) in Github - it will show you also the results I see on my machine.

https://github.com/LironSimon/Prediction-of-Projectile-Landing-Points-with-ML/blob/alex/building_a_dataset.ipynb

These are easy to run also on Google Colab or Mybinder.org or others, if you need to reproduce those. Python script is saved from the notebook, so it has all kind of comments that are used for Visual Studio Code. Apparently there is also a PyCharm support for notebooks https://www.jetbrains.com/help/pycharm/jupyter-notebook-support.html

So now you could see my code, and just copy those lines you want to yours. if we move to another workflow, where I change your code, we will need to agree how to overwrite each one's changes. it's a matter of agreement.