search

Lirt / velero-plugin-for-openstack

Openstack Cinder, Manila and Swift plugin for Velero backups
MIT License
27 stars 16 forks source link

Introduce Option to omit VolumeBackup container option #112

Open modzilla99 opened 6 months ago

modzilla99 commented 6 months ago

When using Ceph RBD Backup driver, the container attr set when creating a VolumeSnapshot has to either correspond to the backup rbd pool or be omitted. Many users might not know which rbd_pool that is, so it should just be omitted in that case. Similar to #107

Since most OS clouds use ceph, it might even make sense to omit it by default and let the user have to explicitly set it. Any thoughts?

Lirt commented 6 months ago

Hello, thank you for PR.

I will need some days to get to this due to business trips. Thank you for patience.

Lirt commented 4 months ago

Hello @modzilla99,

I apologize. I completely forgot about this PR. Let me recheck this.

Is the PR ready? It still has [WIP] in title.

Lirt commented 4 months ago

The idea makes sense to me.

Lirt commented 3 months ago

@modzilla99 The MR still has WIP title. Let me know when you are finished and remove the WIP from title please.

Lirt commented 3 months ago

Hi, there are conflicts in the PR. Can you please fix them?

Also you can use comment to let me know when it's fixed so that I'm notified. It will be faster to merge this PR.