search

Lirt / velero-plugin-for-openstack

Openstack Cinder, Manila and Swift plugin for Velero backups
MIT License
27 stars 16 forks source link

Bump Gophercloud to the latest greatest v2 #118

Closed EmilienM closed 2 weeks ago

EmilienM commented 2 weeks ago

This PR bumps the Gophercloud library so you have the latest greates from it.

2 commits: the bump and the code changes needed for v2, all minor.

EmilienM commented 2 weeks ago

cc @Lirt

Lirt commented 2 weeks ago

Hello @EmilienM,

thank you for generous contribution.

I will fully look into it in the next days but I had a quick look around and I see that you committed /vendor directory. Is this somehow important to be added in this project? We have a very simple dependency list and I don't understand what is this supposed to solve or improve.

EmilienM commented 2 weeks ago

thank you for generous contribution.

My pleasure. Just so you know, I'm a Gophercloud maintainer and a Red Hat employee who is interested to add this plugin into our downstream product.

I will fully look into it in the next days but I had a quick look around and I see that you committed /vendor directory. Is this somehow important to be added in this project? We have a very simple dependency list and I don't understand what is this supposed to solve or improve.

I didn't realize you were not vendoring :man_facepalming: . I removed the directory. Thanks

Lirt commented 2 weeks ago

:smiley: That's fine.

I remember you from my devstack-action PR :+1:.

EmilienM commented 2 weeks ago

Oh right, https://github.com/EmilienM/devstack-action/pull/9 hi ! Small world :)

Lirt commented 2 weeks ago

I see that we also need to bump go version in CI, can you please change it?

I will need to spend some time bumping CI deps later on.

Lirt commented 2 weeks ago

Everything looks good.

Thank you for contribution :pray: .