search

Lirt / velero-plugin-for-openstack

Openstack Cinder, Manila and Swift plugin for Velero backups
MIT License
27 stars 13 forks source link

fix: use proper platform when building 2nd stage docker image #32

Closed clementnuss closed 2 years ago

clementnuss commented 2 years ago

A follow-up of #30 which permits to effectively use the arm or arm64 images

Lirt commented 2 years ago

Hi,

Thank you for MR.

I read the multi-arch build blog from docker and also checked how Velero is building their images.

I like the multiplatform build with BuildKit overall. I created new MR #33 that that is done in a similar way as Velero does. I think it does the build in more Docker Buildkit native way than I was doing before.

Is it OK, to use that MR for you? If yes, can you do the review?

clementnuss commented 2 years ago

Sure, let's do it like that! I close this MR then 👍🏻