Closed kayrus closed 1 year ago
Hi, thank you for PR. I think it looks good.
Can you please rebase on master? I updated CI to run tests on PRs https://github.com/Lirt/velero-plugin-for-openstack/pull/52.
Maybe we can also add a small test for ReplaceAccount()
function.
@Lirt done
Hi @kayrus,
I added one commit with tests - I hope it's OK (if not you can remove it and do by yourself). If yes, please check if those tests make sense or update them.
I think the change is good overall and we can merge it you're fine with it.
I will add update versions afterwards and release as v0.5.0. I don't yet have release process in CI (will try to add it soon), so I'll need to do it manually.
Thanks. Tests are fine with me. As for the clouds.yaml, the endpoint override must be implemented in gophercloud/utils first. And at first glance it's not so trivial as it looks like.
Oh. One more thing. Could you please replace a bucket
term with a container
? Logs that contain bucket
term confuse with S3 buckets.
UPD: I'll create a new PR for this.
As for the clouds.yaml, the endpoint override must be implemented in gophercloud/utils first. And at first glance it's not so trivial as it looks like.
Hi again, so for now can we skip clouds.yaml
integration and merge as it is?
Yes, for now I think we can skip clouds.yaml
.
Thanks. When can I expect a new release?
I just released it :tada: - v0.5.0
.
Fixes #50