Lirt / velero-plugin-for-openstack

Openstack Cinder, Manila and Swift plugin for Velero backups
MIT License
26 stars 12 forks source link

Add an ability to create full clone instead of snapshot #81

Closed kayrus closed 1 year ago

kayrus commented 1 year ago

Resolves #78

kayrus commented 1 year ago

I think it makes sense to rename the clone: "true" to method: clone. The reason behind this:

kayrus commented 1 year ago

I think I'll split this PR into a couple: metadata, configurable timeouts and new snapshot methods

kayrus commented 1 year ago

@Lirt ready for review

Lirt commented 1 year ago

Hi @kayrus, the code looks great as usual.

I spent a while comparing the Manila snapshot and clone method. As far as I understand Manila doesn't have clone operation supported in backend and the difference there is that clone method will create snapshot and immediately create share from it and then remove snapshot while snapshot method will keep only snapshot of the share. Is it correct?

I added one comment regarding review, but it's (again) only about log message.

kayrus commented 1 year ago

Is it correct?

correct.

Lirt commented 1 year ago

Ready for merge?

kayrus commented 1 year ago

@Lirt yes