Closed kayrus closed 1 year ago
I think it makes sense to rename the clone: "true"
to method: clone
. The reason behind this:
I think I'll split this PR into a couple: metadata, configurable timeouts and new snapshot methods
@Lirt ready for review
Hi @kayrus, the code looks great as usual.
I spent a while comparing the Manila snapshot and clone method. As far as I understand Manila doesn't have clone operation supported in backend and the difference there is that clone
method will create snapshot and immediately create share from it and then remove snapshot while snapshot
method will keep only snapshot of the share. Is it correct?
I added one comment regarding review, but it's (again) only about log message.
Is it correct?
correct.
Ready for merge?
@Lirt yes
Resolves #78