search

Liryna / FacebookBot

A Facebook bot for Telegram
MIT License
50 stars 24 forks source link

Added cross platform picture sharing, group name in received message #3

Closed icecube45 closed 8 years ago

icecube45 commented 8 years ago

Also removed the config.json and replaced it with a username and password in the bot constructor. In order for cross platform picture sharing to work, replace the "BOT DIRECTORY GOES HERE", with the directory that holds the bot code.

Liryna commented 8 years ago

OH ! I will review this when I can :heart: !!

Is it normal that you changed the link here ? After accepting the pull request this gonna be fixed automatically. https://github.com/icecube45/FacebookBot/commit/e9ada4d39e09743265dbb84d73518efad7e92e26#diff-04c6e90faac2675aa89e2176d2eec7d8L4

icecube45 commented 8 years ago

Oop, I did that for my own testing, let me update that back.

Liryna commented 8 years ago

Thank you ! This seems to work great but we also get the name of the group when it is a private talk :( Do you think you could fix it ?

Great work and thanks for updating the dependency !

icecube45 commented 8 years ago

You mean if it is a one on one conversation, you will get "Name: Name: hello" ? If so, I can give it a shot, no guarantees

Liryna commented 8 years ago

Yes thats right. If I remember you can get list of people of the conversation (not sure)

icecube45 commented 8 years ago

That's what I'm checking...

It appears telegram's bot api might be a bit broken right now? I keep getting an error when the bot tries to send a message (via both the wrapper and the web call).

Liryna commented 8 years ago

Telegram seems to be alright for me

icecube45 commented 8 years ago

Hmm, that concerns me, I'll investigate more.

icecube45 commented 8 years ago

Telegram api is working again, fixed the group message thing.

Liryna commented 8 years ago

Thank you @icecube45 great work :) !