LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

Combine apply and verify function #1050

Closed shuse2 closed 5 years ago

shuse2 commented 5 years ago

Description

Currently verify and apply has similar functionality, where verify - check if the transaction is verified against current blockchain state apply - check if the transaction is verified against current blockchain state and previously applied state

However, this can be combined into apply as long as apply doesn't mutate the input.

Therefore, for more easier creation of custom creation, it should be merged into one function.

Also, verify section should be refactored and split into more smaller function and combined.