The P2P class should not interact directly with Peer instances

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server

https://lisk.io/

GNU General Public License v3.0

250 stars 64 forks source link

The P2P class should not interact directly with Peer instances #1058

Closed jondubois closed 5 years ago

jondubois commented 5 years ago

Expected behavior

The P2P class should not interact with live Peer instances directly because we should only interact with them from a single place (which is PeerPool). The P2P class should only deal with P2PPeerInfo objects.

Actual behavior

Currently, the P2P class fetches live Peer objects from the peer pool and calls methods on them.

jondubois commented 5 years ago

This issue was closed by https://github.com/LiskHQ/lisk-elements/pull/1067