fromJSON() method provided an extra way of creating transactions that was not needed
create() method had to be removed
How did I fix it?
Remove fromJSON for each custom transactions because having 2 ways to instantiate the class is bit confusing for user.
Remove create for each custom transactions to obtain the signed transaction.
Instead, each create transaction function (0_transfer, etc) should use the custom class created instead.
What was the problem?
fromJSON()method provided an extra way of creating transactions that was not neededcreate()method had to be removedHow did I fix it?
Remove fromJSON for each custom transactions because having 2 ways to instantiate the class is bit confusing for user.
Remove create for each custom transactions to obtain the signed transaction. Instead, each create transaction function (0_transfer, etc) should use the custom class created instead.
How to test it?
Review checklist