Change selectPeers function to only handle detailed PeerInfo objects; not live Peer objects Closes#1059

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server

https://lisk.io/

GNU General Public License v3.0

250 stars 64 forks source link

Change selectPeers function to only handle detailed PeerInfo objects; not live Peer objects Closes#1059 #1067

Closed ishantiw closed 5 years ago

ishantiw commented 5 years ago

Description

Currently, the selectPeers function accepts and returns a list of Peer objects (ReadonlyArray<Peer>). We should make the selectPeers function in peer_selection.ts work with detailed peer info objects instead of live Peer objects.

Review checklist

The PR resolves #1059
All new code is covered with unit tests
All new code was formatted with Prettier
Linting passes
Tests pass
Commit messages follow the commit guidelines
Documentation has been added/updated

ishantiw commented 5 years ago

comments are addressed