Fix compatibility issues with Core v1.x version - Githubissues

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server

https://lisk.io/

GNU General Public License v3.0

250 stars 64 forks source link

Fix compatibility issues with Core v1.x version #1077

Closed jondubois closed 5 years ago

jondubois commented 5 years ago

Expected behavior

The P2P library should be able to connect to the existing Lisk core testnet and communicate with the nodes as a v1 lisk-core node would.
A socket error in the P2P library should be handled and emitted as an event so that it does not crash the P2P node.

Actual behavior

The P2P library has trouble connecting and interacting with the current Lisk core version. There are issues with missing fields which are causing handshake failure.
If one of the peers causes socket failure, it crashes the P2P library.

Steps to reproduce

Check the branch add_p2p_sample_script