There were some remaining issues related to incompatible fields which prevented the P2P library from connecting and interacting with lisk-core v1.x.x nodes.
How did I fix it?
Fixed fields to match those in the current v1 protocol exactly.
Handled socket errors and emit them as events so that they do not crash the P2P node.
Disable ping timeouts since they are not needed for our use case.
Do not force the os field to be an alpha-only string. Often they have dots, dashes and version numbers in them which is OK.
How to test it?
npm run test
Use the sample/index script in add_p2p_sample_script branch to test against v1 testnet.
What was the problem?
There were some remaining issues related to incompatible fields which prevented the P2P library from connecting and interacting with lisk-core v1.x.x nodes.
How did I fix it?
osfield to be an alpha-only string. Often they have dots, dashes and version numbers in them which is OK.How to test it?
npm run testsample/indexscript inadd_p2p_sample_scriptbranch to test against v1 testnet.Review checklist