LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

Change to allow number for fee and amount in constructor #1097

Closed shuse2 closed 5 years ago

shuse2 commented 5 years ago

What was the problem?

In current protocol, for amount and fee should be allowed to be passed in constructor.

How did I fix it?

Update TransactionJSON to be string | number and updated BigNum definition

How to test it?

Pass in amount or fee as number in constructor and observe it doesn't throw error

Review checklist