LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

Remove duplicate balance error - Closes #1105 #1107

Closed mitsuaki-u closed 5 years ago

mitsuaki-u commented 5 years ago

What was the problem?

verifyBalance called in Base (for fee check) and in Transfer (and other amount transactions) causing duplicate insufficient balance errors.

How did I fix it?

In Transfer, InTransfer, and OutTransfer: added extra check to make sure balance had at least enough funds for the fee, before returning balance error for amount to avoid duplicate errors.

How to test it?

npm test

Review checklist