Add hoist option to bootstrap - Githubissues

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server

https://lisk.io/

GNU General Public License v3.0

250 stars 64 forks source link

Add hoist option to bootstrap #1116

Closed shuse2 closed 5 years ago

shuse2 commented 5 years ago

What was the problem?

Installation time was very long with duplicate package in each library.

How did I fix it?

Added hoist option on bootstrap, so devDependencies are managed in root level

How to test it?

rm -rf ./node_modules
npm run clean
npm run clean:node_modules
npm i
npm run build
npm t
cd packages/xxx
npm run build
npm t

Review checklist

The PR resolves #1079
All new code is covered with unit tests
All new code was formatted with Prettier
Linting passes
Tests pass
Commit messages follow the commit guidelines
Documentation has been added/updated

ishantiw commented 5 years ago

Looks good but as pointed out by @pablitovicente browsertests are failing. I added line "types": ["mocha", "node"] in compilerOptions and updated line "include": ["../../types/**/*", "src/**/*", "test/**/*", "types/**/*"] in tsconfig.browsertest.json and it works.