search

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

Need a function to resolve peers domain names to their IP addresses #1138

Closed ishantiw closed 5 years ago

ishantiw commented 5 years ago

Expected behavior

In case domain names are used, resolve those to IP addresses.

Actual behavior

There is no function to handle if a domain name is used by a peer. So we need to add this check in validation functions that sanitize peer info objects coming from the network.

shuse2 commented 5 years ago

Decided that this should be done in the module level. As for a library, we decided not to have this feature for performance reason.