LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

null recipientPublicKey should not fail validation #1142

Closed pablitovicente closed 5 years ago

pablitovicente commented 5 years ago

Expected behavior

If a null recipientPublicKey property is present in a transaction it should be accepted

Actual behavior

Currently it's not being accepted although TransactionJSON defines it as optional string we might need to accept null and/or undefined here.

Steps to reproduce

Run any of the GET functional tests in core for example mocha framework/test/functional/http/get/node/transactions_unsigned.js

Which version(s) does this affect? (Environment, OS, etc...)