null recipientPublicKey should not fail validation - Closes #1142 - Githubissues

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server

https://lisk.io/

GNU General Public License v3.0

250 stars 64 forks source link

null recipientPublicKey should not fail validation - Closes #1142 #1143

Closed pablitovicente closed 5 years ago

pablitovicente commented 5 years ago

What was the problem?

null recipientPublicKey was failing validation

How did I fix it?

by setting recipientPublicKey to empty string if null

How to test it?

Build should be green
Transactions generated by lisk.elements 1.0.0 can be passed to the constructors of 2.1 (this is the scenarios in lisk-core currently where tests use lisk elements but core starting to use 2.1.x)

Review checklist

The PR resolves #1142
All new code is covered with unit tests
All new code was formatted with Prettier
Linting passes
Tests pass
Commit messages follow the commit guidelines
Documentation has been added/updated