Fix fee property not to be set in the constructor - Closes #1144 - Githubissues

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server

https://lisk.io/

GNU General Public License v3.0

250 stars 64 forks source link

Fix fee property not to be set in the constructor - Closes #1144 #1146

Closed shuse2 closed 5 years ago

shuse2 commented 5 years ago

What was the problem?

Constructor was assigning the default fee, but it for genesis block, it was 0 fee

How did I fix it?

Remove fee assignment in constructor and only validate

How to test it?

apply genesis block or npm t

Review checklist

The PR resolves #1144
All new code is covered with unit tests
All new code was formatted with Prettier
Linting passes
Tests pass
Commit messages follow the commit guidelines
Documentation has been added/updated