LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

UndoAsset for transactions should revert the properties instead of removing them #1177

Closed SargeKhan closed 5 years ago

SargeKhan commented 5 years ago

Expected behavior

In the case of undoing transaction, the transaction should revert the changes made to the accounts involved in the transaction.

Actual behavior

When undoAsset function is called, it strips the properties which were updated by the transaciton. Which, in turn, leaves the responsibility of assigning a default value to the properties on the application. It is not the correct behavior.

Which version(s) does this affect? (Environment, OS, etc...)

2.1.0