search

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

The format defined for "fee" property should allow 0 as value #1184

Closed SargeKhan closed 5 years ago

SargeKhan commented 5 years ago

Expected behavior

The fee for all transactions in the genesis block is 0. Therefore, the validation for the format fee should pass when the fee is equal to 0.

Actual behavior

The schema validation fails for a transaction if the value of the property fee is zero.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

shuse2 commented 5 years ago

i think it make more sense to fail but ignored?

shuse2 commented 5 years ago

Closing because genesis block is handled differently