search

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

Update transaction to hold blockchain related property #1199

Closed shuse2 closed 5 years ago

shuse2 commented 5 years ago

What was the problem?

Transaction was not able to hold blockchain related properties.

How did I fix it?

Add blockchain properties in constructor, and toJSON

How to test it?

instantiate the transaction with blockId, height and condirmations, and call toJSON to make sure it holds the data

Review checklist