search

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

Convert optional field null to undefined #1204

Closed shuse2 closed 5 years ago

shuse2 commented 5 years ago

What was the problem?

Optional field should accept null and undefined for the validation

How did I fix it?

In constructor, change the null to undefined

How to test it?

npm t

Review checklist

SargeKhan commented 5 years ago

@shuse2 , did you check other transaction types? I think we should do this for all transaction definitions.

shuse2 commented 5 years ago

@SargeKhan Yes, base transaction is covered, and for asset, I think there is no optional field for other transactions