LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

applyNodeInfo is not adding custom fields anymore #1209

Closed jondubois closed 5 years ago

jondubois commented 5 years ago

Expected behavior

The P2P instance should forward an exact copy of the nodeInfo object to peers.

Actual behavior

Right now it's not copying all the fields and this causes the EVENT_FAILED_TO_PUSH_NODE_INFO event to trigger.

Steps to reproduce

This was discovered while implementing synching with the v1 testnet.