LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server
https://lisk.io/
GNU General Public License v3.0
250 stars 64 forks source link

fix dappId constraint #1229

Closed SargeKhan closed 5 years ago

SargeKhan commented 5 years ago

What was the problem?

OutTransfer transaction implementation checks whether dappId creator is the creator of the outtransfer transaction, which is not the current behaviour of lisk-core and it fails when syncing with testnet.

How did I fix it?

For OutTransfer transaction, the transaction which is specified in the dappId should be a dapp registeration transaction, irrespective of whether the sender of out transfer transaction is the creator of the transaction specified in the dappID.

How to test it?

Sync against testnet.

Review checklist