Multi-signature registration - Create member accounts - Closes #1227 - Githubissues

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server

https://lisk.io/

GNU General Public License v3.0

250 stars 64 forks source link

Multi-signature registration - Create member accounts - Closes #1227 #1230

Closed pablitovicente closed 5 years ago

pablitovicente commented 5 years ago

What was the problem?

Group member accounts were not being created when registering a multi-signature transaction

How did I fix it?

By adding methods to fetch/create the group member accounts

How to test it?

Build should be green
Register a multi-signature with two members and the two members should have accounts created
Credit two accounts, register multi-signature for the first one and use the second one and another one as members. Registration should succeed and second account should have same balance

Review checklist

The PR resolves #1227
All new code is covered with unit tests
All new code was formatted with Prettier
Linting passes
Tests pass
Commit messages follow the commit guidelines
Documentation has been added/updated

shuse2 commented 5 years ago

Closing but need to re-open on another repositorry