search

LiskArchive / lisk-engine

:bullettrain_front: Lisk blockchain engine
https://lisk.com
Apache License 2.0
0 stars 0 forks source link

Unit tests in p2p are compliant with internal coding standard #53

Closed matjazv closed 1 year ago

matjazv commented 1 year ago

What was the problem?

This PR resolves #44.

How was it solved?

Unit tests in p2p/v2 were refactored to follow convention about assert and context usage.

How was it tested?

All unit tests passed.

shuse2 commented 1 year ago

@matjazv I think for the test related stuff, the name should be xxx_test.go. Probably, we can move these things in p2p_test.go?

matjazv commented 1 year ago

@matjazv I think for the test related stuff, the name should be xxx_test.go. Probably, we can move these things in p2p_test.go?

That's a good solution.