search

LiskArchive / lisk-explorer

📦 Lisk blockchain explorer
https://explorer.lisk.io/
GNU General Public License v3.0
121 stars 65 forks source link

Displays only 0.5.0 #22

Closed ghost closed 7 years ago

ghost commented 7 years ago

https://explorer.lisk.io/networkMonitor

Displays only 0.5.0 while i can clearly see in logs on my nodes that other version still exists on network.

Isabello commented 7 years ago

This is a non issue.

On Nov 30, 2016 10:12, "Unhandled Exception" notifications@github.com wrote:

https://explorer.lisk.io/networkMonitor

Displays only 0.5.0 while i can clearly see in logs on my nodes that other version still exists on network.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LiskHQ/lisk-explorer/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/APzFsE0QqP3fwWSlsxLVUgtv1g63RLSGks5rDaBrgaJpZM4LAX7J .

ghost commented 7 years ago

It's incorrect anyway, there are other nodes version than 0.5.0, im aware nodes below 0.5.0 are dropped but network monitor result is wrong.

Is current count only 0.5.0 or all including old ones ? How much are not updated yet ?

4miners commented 7 years ago

Network monitor should only show peers that are in network (or was lately and now are disconnected). Since all nodes with version lower than 0.5.0 are rejected by network - they are no longer a part of it. Such behavior is correct.

ghost commented 7 years ago

Nodes below 0.5.0 are still part of network, but cannot participate due protocol changes in latest version. It's network monitor, it should display all nodes from beginning, possibly marking those incompatible with current network protocol as harmful/useless or whatever. Monitor goal is to actually monitor network, see adoption of new releases including those which will remove support for previous versions. This is my understanding of this and i believe it's correct, most Bitcoin monitors keep it this way as well. It would be much cleaner and better to display everything and mark those below 0.5.0 as incompatible with latest changes.

Isabello commented 7 years ago

Nodes below 0.5.0 are not part of the network. they cannot communicate with any peers on 0.5.x or above. There is nothing gained by monitoring these peers.

Nodes pre 0.5.x are completely incompatible. Future releases, such as 0.5.1a, monitoring adoption will be possible.

If this were truly an issue it would need to be addressed as part of core relating to the removal of peers. You won't see any movement there as the code is clearly designed to remove peers entirely from the DB on EVERSION, this prevents them from ever making it into the DB and causing writes.

Isabello commented 7 years ago

This part of the code here is why this is a wontfix. I will leave this open for further discussion for the next day or two but im not convinced its an issue when it comes to nodes on entirely incompatible versions.

https://github.com/LiskHQ/lisk/blob/360c73a73ec7cb0ef184a4ea6a07a80e51c10860/modules/transport.js#L557

ghost commented 7 years ago

Im aware that nodes below 0.5.0 are removed, but explorer is for statistics as well, currently we can't know how many old versions is still running. that's all I'm saying.

4miners commented 7 years ago

Statistics about peers running older incompatible versions are simply not available in core, so explorer doesn't have a source to pull from. Imo tracking for those should not be added because of work amount compared to possible benefit gain. Also core should be efficient so littering it with unnecessary data doesn't make sense.

If anyone need those statistics - it's possible to get them by connecting explorer to old version node.

Isabello commented 7 years ago

I would say this is definitely closed now. You can log this issue with core but I don't see us changing the way EVERSION works.