Isabello
commented
7 years ago We could address this here,
https://github.com/LiskHQ/lisk/blob/ccd58052aa33148ab2652d97e0a85edcf8ffd016/modules/loader.js#L403
var peer = network.peers[Math.floor(Math.random() * network.peers.length)];
But instead we would probably want to have some validation that the IP is not our own. The best place to address this would instead be here:
https://github.com/LiskHQ/lisk/blob/ccd58052aa33148ab2652d97e0a85edcf8ffd016/modules/peers.js#L245
Peers.prototype.acceptable = function (peers) {
return _.chain(peers).filter(function (peer) {
// Removing peers with private ip address
return !ip.isPrivate(peer.ip);
}).uniqWith(function (a, b) {
// Removing non-unique peers
return (a.ip + a.port) === (b.ip + b.port);
// Slicing peers up to maxPeers
}).slice(0, constants.maxPeers).value();
};We could add logic to remove peers that match our IP address to prevent the peer from becoming a valid selection target and to be put on the DB table.
ghost
I've noticed that after some time after starting 0.5.0. Node stucks on getting blocks from itself. Possible solutions:
Restarting node fix problems temporary, usually for not so long.