LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 454 forks source link

API /api/node/constants missing build field #3848

Closed ManuGowda closed 5 years ago

ManuGowda commented 5 years ago

Expected behavior

/api/node/constants should include build info in response

Actual behavior

2.0.0 response

{
"meta": {},
"data": {
"commit": "2b5272085566ad043be8b223afae2af5ab89fefe",
"epoch": "2016-05-24T17:00:00.000Z",
"fees": {
"send": "10000000",
"vote": "100000000",
"secondSignature": "500000000",
"delegate": "2500000000",
"multisignature": "500000000",
"dappRegistration": "2500000000",
"dappWithdrawal": "10000000",
"dappDeposit": "10000000"
},
"nethash": "198f2b61a8eb95fbeed58b8216780b68f697f26b849acf00c8c93bb9b24f783d",
"nonce": "CR22NMPC07s8juQQ",
"milestone": "0",
"reward": "0",
"supply": "10000000000000000",
"version": "2.0.0-alpha.12",
"protocolVersion": "1.0"
},
"links": {}
}

1.6.0 response

{
"meta": {},
"data": {
"build": "2019-04-24T10:49:37.000Z",
"commit": "40e2e86021ad14661dea78932d638a2a5bb53835",
"epoch": "2016-05-24T17:00:00.000Z",
"fees": {
"send": "10000000",
"vote": "100000000",
"secondSignature": "500000000",
"delegate": "2500000000",
"multisignature": "500000000",
"dappRegistration": "2500000000",
"dappWithdrawal": "10000000",
"dappDeposit": "10000000"
},
"nethash": "ed14889723f24ecc54871d058d98ce91ff2f973192075c0155ba2b7b70ad2511",
"nonce": "xlQGt8pMBh3Fq7yf",
"milestone": "2",
"reward": "300000000",
"supply": "13301172100000000",
"version": "1.6.0",
"protocolVersion": "1.0"
},
"links": {}
}

Steps to reproduce

Deploy 2.0.0 and 1.6.0 node and check /api/node/constants for the response

Which version(s) does this affect? (Environment, OS, etc...)

2.0.0

ManuGowda commented 5 years ago

I tested this issue on source and the build field is present only for binary and docker release. so closing this issue.