search

LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 456 forks source link

All framework plugin must use the same framework version #6045

Closed shuse2 closed 2 years ago

shuse2 commented 3 years ago

Expected behavior

plugin should be independent on each other, and if it's patch release, it should be possible to install different version.

Actual behavior

framework contains external_types for the axon, and these types will be defined twice, and it will not be able to be built.

Steps to reproduce

Try to install 2 packages which use different framework version

Additional information

possible mitigation will be to remove the usage of axon and use the raw IPC, which will not require types. Similar implementation already exists in ws.

Which version(s) does this affect? (Environment, OS, etc...)

5.0.0-

shuse2 commented 2 years ago

axon is removed, so this will no longer be a problem