Update request id handling on JSONRPC - Githubissues

LiskArchive / lisk-sdk

🔩 Lisk software development kit

https://lisk.com

Apache License 2.0

2.72k stars 456 forks source link

Update request id handling on JSONRPC #6698

Closed ishantiw closed 11 months ago

ishantiw commented 3 years ago

Description

Currently when request.id is used, it is casted with as string. This casting needs to be removed.

https://github.com/LiskHQ/lisk-sdk/blob/feature/6554-improve-framework-architecture/framework/src/controller/request.ts#L28

action.id now called request.id is string | null | number to comply with JSONRPC 2.0, but we only expect string

Acceptance Criteria

Request must be compatible with JSONRPC 2.0
All unit tests should pass
All integration tests should pass
All functional tests should pass

shuse2 commented 11 months ago

Closing this issue since this is no longer valid