search

LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 454 forks source link

Incorrect naming `const allKeys = ....` #7446

Closed sitetester closed 9 months ago

sitetester commented 2 years ago

Description

const allKeys = [...params.mandatoryKeys, ...params.optionalKeys].map((key, index) => ({
    key,
    signature: params.signatures[index],
}));

Here allKeys should be renamed to signaturesByKey

Motivation

Since it contains combination of signature & key & not just all keys.

Additional Information

framework/src/modules/auth/commands/register_multisignature.ts

shuse2 commented 9 months ago

Closing this issue for no activity