[base_interoperability_store.ts] duplicated code block inside `createTerminatedStateAccount`

[sitetester]

Description

if (stateRoot) {
    if (isExist) {
        const chainAccount = await chainSubstore.get(this.context, chainID);
        chainAccount.status = CHAIN_TERMINATED;
        await chainSubstore.set(this.context as StoreGetter, chainID, chainAccount);
        const outboxRootSubstore = this.stores.get(OutboxRootStore);
        await outboxRootSubstore.del(this.context as StoreGetter, chainID);
    }
    terminatedState = {
        stateRoot,
        mainchainStateRoot: EMPTY_BYTES,
        initialized: true,
    };
} else if (isExist) {
    const chainAccount = await chainSubstore.get(this.context, chainID);
    chainAccount.status = CHAIN_TERMINATED;
    await chainSubstore.set(this.context as StoreGetter, chainID, chainAccount);
    const outboxRootSubstore = this.stores.get(OutboxRootStore);
    await outboxRootSubstore.del(this.context as StoreGetter, chainID);

    terminatedState = {
        stateRoot: chainAccount.lastCertificate.stateRoot,
        mainchainStateRoot: EMPTY_BYTES,
        initialized: true,
    };
}

Here following code block is duplicated, should be moved to outside of ifs

const chainAccount = await chainSubstore.get(this.context, chainID);
chainAccount.status = CHAIN_TERMINATED;
await chainSubstore.set(this.context as StoreGetter, chainID, chainAccount);
const outboxRootSubstore = this.stores.get(OutboxRootStore);
await outboxRootSubstore.del(this.context as StoreGetter, chainID);

Motivation

Please describe why it is needed

Additional Information

• framework/src/modules/interoperability/base_interoperability_store.ts

[shuse2]

Closing this issue for no activity