Rename `isValidName(...)` to `isValidChainName(...)` - Githubissues

LiskArchive / lisk-sdk

🔩 Lisk software development kit

https://lisk.com

Apache License 2.0

2.72k stars 456 forks source link

Rename `isValidName(...)` to `isValidChainName(...)` #7776

Closed sitetester closed 11 months ago

sitetester commented 2 years ago

Description

export const isValidName = (username: string): boolean => /^[a-z0-9!@$&_.]+$/g.test(username);

At some point, we should rename isValidName((...) to be more specific like isValidChainName(...),

Motivation

isValidName is too generic name, which could mean any name
It's public & globally available
We can unintentionally use this function elsewhere with similar name

Additional Information

framework/src/modules/interoperability/utils.ts
https://github.com/LiskHQ/lisk-sdk/pull/7770

shuse2 commented 11 months ago

Closing this issue for no activity