Missing test cases in state recovery init command - Githubissues

LiskArchive / lisk-sdk

🔩 Lisk software development kit

https://lisk.com

Apache License 2.0

2.72k stars 455 forks source link

Missing test cases in state recovery init command #7970

Closed mitsuaki-u closed 1 year ago

mitsuaki-u commented 1 year ago

Expected behavior

Missing tests from QA sheet:

trs.params.chainID is empty
`terminatedStateAccount(trs.params.chainID) does not exist (and the previous conditions return True)

Extra exception logic included in code that was not in LIP specs to investigate: In verify hook:

        if (!terminatedStateAccount.mainchainStateRoot) {
                throw new Error('Sidechain account has missing property: mainchain state root');
            }

Recommend updating error message to Sidechain account in terminated state has missing property: mainchain state root

Actual behavior

Missing tests

Steps to reproduce

Cross check QA sheet with code

Which version(s) does this affect? (Environment, OS, etc...)

Development

sitetester commented 1 year ago

Similar task - https://github.com/LiskHQ/lisk-sdk/issues/8193