search

LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 454 forks source link

[initialize_state_recovery.spec.ts] has invalid tests for `execute` part #8068

Closed sitetester closed 9 months ago

sitetester commented 1 year ago

While reviewing PR https://github.com/LiskHQ/lisk-sdk/pull/8064, I noticed there are some incorrect tests written for initialize_state_recovery command describe('execute' section

Although suggestions were provided, but since it involved out of scope change of that PR, it needs to be addressed here.

Steps to reproduce

// framework/test/unit/modules/interoperability/sidechain/commands/initialize_state_recovery.spec.ts

Checking comments on PR https://github.com/LiskHQ/lisk-sdk/pull/8064 & either apply those comments or come with better approach :)

shuse2 commented 9 months ago

Closing this issue for no activity