search

LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 454 forks source link

Align logic for `BFT.setBFTParameters` to use genesis height #8455

Closed shuse2 closed 1 year ago

shuse2 commented 1 year ago

Expected behavior

BFT.setBFTParameters should use genesis height as in LIP

Actual behavior

Currently it's using maxHeightPrevoted. Although the value is initialized with genesis height, it's better to use the consistent approach

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-beta.0

shuse2 commented 1 year ago

We have decided to make the change on LIP and keep the implementation as it is