LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 454 forks source link

Duplicated `ChainAccount` interface #9059

Closed sitetester closed 9 months ago

sitetester commented 1 year ago

Description

There is a duplicated interface in source code, so we can remove one of them. // framework/src/modules/interoperability/stores/chain_account.ts

export const enum ChainStatus {
    REGISTERED = 0,
    ACTIVE = 1,
    TERMINATED = 2,
}
export interface ChainAccount {
    name: string;
    lastCertificate: LastCertificate;
    status: ChainStatus;
}

// framework/src/modules/interoperability/types.ts

export interface ChainAccount {
    name: string;
    lastCertificate: LastCertificate;
    status: number;
}

Some points to consider while removing this duplication:

Motivation

Please describe why it is needed

Additional Information

shuse2 commented 9 months ago

Closing this issue for no activity