search

LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 457 forks source link

Update getMaxRemovalHeight to start from minCerifyHeight - 1 #9060

Closed shuse2 closed 9 months ago

shuse2 commented 9 months ago

What was the problem?

This PR resolves #9057

How was it solved?

Update to use minCertifyHeight to be used instead of genesis height

How was it tested?

codecov[bot] commented 9 months ago

Codecov Report

Merging #9060 (fde95b6) into release/6.0.0 (ab8aa88) will increase coverage by 0.00%. The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #9060   +/-   ##
==============================================
  Coverage          83.51%   83.52%           
==============================================
  Files                603      603           
  Lines              22671    22672    +1     
  Branches            3348     3348           
==============================================
+ Hits               18934    18937    +3     
+ Misses              3737     3735    -2
Files Coverage Δ
framework/src/engine/consensus/consensus.ts 82.72% <100.00%> (ø)
framework/src/engine/generator/generator.ts 83.72% <66.66%> (+0.73%) :arrow_up: