LiskArchive / lisk-sdk

πŸ”© Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 457 forks source link

Simplify getBytes and getSigningBytes #9062

Closed bobanm closed 8 months ago

bobanm commented 9 months ago

What was the problem?

This PR resolves #9061

How was it solved?

How was it tested?

All existing tests have passed πŸ‘ŒπŸ»

codecov[bot] commented 9 months ago

Codecov Report

Merging #9062 (5cf34e9) into development (773ba74) will decrease coverage by 0.90%. Report is 2 commits behind head on development. The diff coverage is 92.85%.

:exclamation: Current head 5cf34e9 differs from pull request most recent head 7608396. Consider uploading reports for the commit 7608396 to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #9062      +/-   ##
===============================================
- Coverage        84.35%   83.46%   -0.90%     
===============================================
  Files              655      604      -51     
  Lines            24137    22776    -1361     
  Branches          3506     3356     -150     
===============================================
- Hits             20361    19010    -1351     
+ Misses            3776     3766      -10     
Files Coverage Ξ”
elements/lisk-transactions/src/validate.ts 100.00% <100.00%> (ΓΈ)
elements/lisk-transactions/src/sign.ts 98.07% <94.44%> (-1.93%) :arrow_down:
framework/src/testing/create_transaction.ts 20.83% <0.00%> (+1.60%) :arrow_up:

... and 103 files with indirect coverage changes