LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 457 forks source link

Update terminate liveness command #9063

Closed sitetester closed 8 months ago

sitetester commented 9 months ago

What was the problem?

This PR resolves #8193

Regarding this point:

Line 126: This test should be reverted. The verify() function throws error when the chain is Live; when it is not live, verification is successful. So, the description should be "should return error if the chain is live" and in line 127 call mockResolvedValue(true).

How was it solved?

How was it tested?

Relevant test added

codecov[bot] commented 9 months ago

Codecov Report

Merging #9063 (1e99a48) into release/6.1.0 (d75cf3a) will decrease coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 1e99a48 differs from pull request most recent head 50bca2f. Consider uploading reports for the commit 50bca2f to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.1.0    #9063      +/-   ##
=================================================
- Coverage          84.33%   84.33%   -0.01%     
=================================================
  Files                652      652              
  Lines              23965    23960       -5     
  Branches            3487     3485       -2     
=================================================
- Hits               20212    20207       -5     
  Misses              3753     3753              
Files Coverage Δ
...chain/commands/terminate_sidechain_for_liveness.ts 100.00% <100.00%> (ø)
framework/src/modules/interoperability/schemas.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes